Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app_generator_service): overload type hints #11507

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(app_generator_service): overload type hints #11507

merged 2 commits into from
Dec 10, 2024

Conversation

laipz8200
Copy link
Member

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 9, 2024
@laipz8200 laipz8200 changed the title Fix/overload type hints fix(app_generator_service): overload type hints Dec 9, 2024
@laipz8200 laipz8200 requested a review from crazywoola December 9, 2024 17:42
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@crazywoola crazywoola merged commit fd354d9 into main Dec 10, 2024
8 checks passed
@crazywoola crazywoola deleted the fix/overload-type-hints branch December 10, 2024 01:06
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
@laipz8200 @iamjoel
fix(app_generator_service): overload type hints (#11507)
0deb19e 
Signed-off-by: -LAN- <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laipz8200 @crazywoola